From: Giovanni Campagna <gcampagna@src.gnome.org>
Date: Sat, 26 Mar 2011 14:57:23 +0000 (+0100)
Subject: MessageTray: don't forward click on sources with notifications
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~8422
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=96c2b5ef323cb73db3a3d602681e71c1a6de1327;p=gnome-shell.git

MessageTray: don't forward click on sources with notifications

When a source has an associated tray icon, we would forward all clicks
to the X11 window, meaning that the summary notification could not
be opened. Instead, restore normal event flow for clicks, when the
source has notifications in the queue.

https://bugzilla.gnome.org/show_bug.cgi?id=645753
---

diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js
index c3ae212ac..d2a50d0e3 100644
--- a/js/ui/notificationDaemon.js
+++ b/js/ui/notificationDaemon.js
@@ -465,6 +465,14 @@ Source.prototype = {
         if (event.type() != Clutter.EventType.BUTTON_RELEASE)
             return false;
 
+        // Left clicks are passed through only where there aren't unacknowledged
+        // notifications, so it possible to open them in summary mode; right
+        // clicks are always forwarded, as the right click menu is not useful for
+        // tray icons
+        if (event.get_button() == 1 &&
+            this.notifications.length > 0)
+            return false;
+
         if (Main.overview.visible) {
             // We can't just connect to Main.overview's 'hidden' signal,
             // because it's emitted *before* it calls popModal()...